Skip to content

Handle exceptions thrown during Key Vault reference resolution during startup #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2024
Merged

Handle exceptions thrown during Key Vault reference resolution during startup #518

merged 2 commits into from
Feb 21, 2024

Conversation

@amerjusupovic
Copy link
Contributor

@amerjusupovic amerjusupovic commented Feb 13, 2024 •
edited
Loading

No description provided.

@amerjusupovic amerjusupovic changed the title Handle exception thrown during Key Vault reference resolution Handle exceptions thrown during Key Vault reference resolution during initial load Feb 13, 2024
@amerjusupovic amerjusupovic changed the title Handle exceptions thrown during Key Vault reference resolution during initial load Handle exceptions thrown during Key Vault reference resolution during startup Feb 13, 2024
@amerjusupovic amerjusupovic marked this pull request as draft February 14, 2024 01:46
@amerjusupovic amerjusupovic marked this pull request as ready for review February 16, 2024 19:26
@amerjusupovic amerjusupovic linked an issue Feb 21, 2024 that may be closed by this pull request
Key Vault secret reference resolution should respect startup timeout allowance #516
Closed
@amerjusupovic amerjusupovic merged commit 6ce60b9 into main Feb 21, 2024
@amerjusupovic amerjusupovic deleted the ajusupovic/startup-keyvaultexception branch February 21, 2024 21:23
amerjusupovic added a commit that referenced this pull request Sep 24, 2024
@amerjusupovic
Revert "Handle exceptions thrown during Key Vault reference resolutio…
6e8d22f 
…n during startup (#518)"

This reverts commit 6ce60b9.
@amerjusupovic amerjusupovic mentioned this pull request Sep 24, 2024
Merged
amerjusupovic added a commit that referenced this pull request Sep 25, 2024
@amerjusupovic
Revert "Handle exceptions thrown during Key Vault reference resolutio…
7d89929 
…n during startup (#518)" (#594)

This reverts commit 6ce60b9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rossgrambo rossgrambo rossgrambo approved these changes

@jimmyca15 jimmyca15 Awaiting requested review from jimmyca15

@avanigupta avanigupta Awaiting requested review from avanigupta

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Key Vault secret reference resolution should respect startup timeout allowance

3 participants

@amerjusupovic @rossgrambo